The shape of a good pull request
I've reviewed about ten thousand PRs. The good ones look almost identical. Here's the shape — what to put in the diff, the description, and what to leave on the floor.
Tag
Tag
I've reviewed about ten thousand PRs. The good ones look almost identical. Here's the shape — what to put in the diff, the description, and what to leave on the floor.
The RFC process at the last three places I worked was a way of pretending we were having a conversation. Here's what I do instead.